Deg invalid in units

[Footleg]

Thanks for that. Yes I agree updating the manual to match the behaviour
makes most sense. I'll update my parser to match Survex actual behaviour
too. I'm happy to provide all my test files to the Survex test suite.
They'll be included in my source distribution for cave converter under a
GPL license when I've finished writing them. I'll send you a link when my
release goes out.

Since I added handling of file includes to my parser I've been testing it
against the entire 3 counties system dataset, which has raised some
interesting questions about what should be valid or maybe at least raise a
warning. I added output of splays using anonymous to stations, which
enables my converter to read files with splays flagged using flags in
Survex, and convert them to splays using - instead of a named to station.
This broke some files in the Leck Fell dataset where survey data was joined
the both ends of a splay leg. Survex processed these without warnings,
which I thought was a case where a warning could be useful as it seemed an
unusual thing to do with a leg flagged as a splay. After I converted those
named to stations to - characters it broke the connectivity of these data
sets.

Footleg

On Wed, 11 Jan 2017 22:43 Olly Betts, <olly at survex.com> wrote:

> On Wed, Jan 11, 2017 at 10:18:28PM +0000, Footleg wrote:
> > I was building some test files for my CaveConverter program as I improve
> > the Survex format parsing support. I added units based on the Survex help
> > content:
> >
> > TAPE/LENGTH, BACKTAPE/BACKLENGTH, COUNTER/COUNT, DEPTH, DX/EASTING,
> > DY/NORTHING, DZ/ALTITUDE in YARDS|FEET|METRIC|METRES|METERS (default:
> > METRES)
> >
> > CLINO/GRADIENT, BACKCLINO/BACKGRADIENT in
> > DEG|DEGREES|GRADS|MILS|PERCENT|PERCENTAGE (default: DEGREES)
> >
> > COMPASS/BEARING, BACKCOMPASS/BACKBEARING, DECLINATION in
> > DEG|DEGREES|GRADS|MILS|MINUTES (default: DEGREES)
> >
> > A couple of unexpected things in processing my test file with Survex
> 1.2.30
> >
> > It errored on 'deg' as a unit, saying it was unsupported.
>
> "DEG" should be "DEGS" - I've updated the manual.
>
> > It allowed 'minutes' as a unit for clino (which I entered against the
> help
> > in  and paste error).
>
> In fact there's one standard list of units for angular quantities, and
> percentages are also supported for clinos as a special case.
>
> I've added MINUTES as supported in the manual (it's been supported this for
> ages, so fixing the manual to document it seems better than removing this
> support).
>
> Thanks for spotting and reporting these.
>
> I think it would be useful to add your test files to the Survex test suite,
> so any regressions get caught sooner.  Are you happy to contribute them?
> If so, probably best to let me know when you've completed building them
> and I can add them in one go.
>
> Cheers,
>     Olly
>