LRUD bug in 1.1.9

[Loeffler, David]

Hi Olly,

I'm afraid I've got bad news yet again.

I just got round to downloading 1.1.9. Looks like you introduced a new bug 
while fixing the old bug in img.c. At line 823, it fails to reset 
pimg->pending to 0, so whenever you open a 3d file with any LRUD data it goes 
into an infinite loop after reading the first batch of LRUD data.

823c823,827
<       if (pimg->pending == 256) return img_XSECT_END;
---
>       if (pimg->pending == 256)
>       {
>         pimg->pending = 0;
>         return img_XSECT_END;
>       }

Incidentally, while testing this I hacked up dump3d to output cross-section
data as well -- just a three-line change. I reckon it'd probably be sensible 
to incorporate this into future versions. Here's the diff to dump3d.c:

123a124,126
>         case img_XSECT:
>           printf("XSECT %f %f %f %f [%s]\n", pimg->l, pimg->r, pimg->u, pimg->d, pimg->label);
>           break;




Dave

--
David Loeffler
Mathematics Department
Imperial College, London

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://lists.tartarus.org/pipermail/survex/attachments/20060711/a6d153fc/attachment.html